Fix heap out-of-bounds reads in UTF8Util (issues #794 and #799)#1098
Merged
Fix heap out-of-bounds reads in UTF8Util (issues #794 and #799)#1098
Conversation
Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/b0947f46-348e-413e-b61e-cff5d8a8b865 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/b0947f46-348e-413e-b61e-cff5d8a8b865 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix heap out-of-bound read in UTF8Util.hpp
Fix heap out-of-bounds reads in UTF8Util (issues #794 and #799)
Apr 14, 2026
…tringSliceBase ctor Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/c3e68446-b39f-4c0f-9013-2a3cc42c35d0 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
…iceBase simplification Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/6588ec72-bb39-41f7-a952-29f7ad8c1ae4 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
BYVoid
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Length(): throwsInvalidUTF8on truncated sequence — still avoids reading past\0(uses while loop, MSVC-safe)UTF8StringSliceBase(const char*): reverted to simpleUTF8Util::Length()+strlen()one-linerLengthTruncatedSequencetest:EXPECT_EQ(0, ...)→EXPECT_THROW(..., InvalidUTF8)