ci: refresh Node.js versions (drop 20, add 25)#1109
Merged
Conversation
Node.js 20 is approaching end-of-life; only Node.js 22 (LTS) and 24 are exercised on macOS 14 now, matching the current stable line used on the primary Linux/macOS runners.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d51f36dd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Exercises the current stable line alongside the Node.js 24 LTS on the primary hosted runners.
Widen the supported Node.js range in package.json (and the matching package-lock.json engines entry) to include Node.js 25, aligning with the CI matrix.
BYVoid
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engines.nodeinpackage.json(and the matchingpackage-lock.jsonentry) from>=20 <25to>=20 <=25so Node.js 25 is permitted.Changes
.github/workflows/nodejs.yml:ubuntu-latest/macos-latest.package.json/package-lock.json:"node": ">=20 <=25".Rationale
Node.js 20 moves to EOL soon, so keeping it in the CI matrix adds noise without real coverage. Node.js 25 is the current stable release per nodejs.org; exercising it on the primary runners catches regressions against the newest line while Node.js 24 LTS remains the production recommendation.
https://claude.ai/code/session_017xps8CYCFXzRKeTUsKm1Ca