fix: correct Hong Kong place name conversions for 干諾道 and 鰂魚涌#1110
Merged
fix: correct Hong Kong place name conversions for 干諾道 and 鰂魚涌#1110
Conversation
…t cases Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/c0fd7ab2-cf53-42d9-90d9-2f2d637c60d4 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
frankslin
April 14, 2026 22:04
View session
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two HK place names were converting incorrectly in all S→Traditional modes due to missing phrase entries and default character-level mappings overriding the intended forms.
干諾道(Connaught Road):干defaults to幹viaSTCharacters.txt, producing幹諾道. Added phrase entries toSTPhrases.txtso the full road name takes precedence:干诺道 → 干諾道干诺道中 → 干諾道中干诺道西 → 干諾道西鰂魚涌(Quarry Bay): Entry鲗鱼涌 → 鰂魚涌already exists inSTPhrases.txtand converts correctly; no change needed.testcases.jsoncovering both place names acrosss2t,s2hk,s2tw, ands2twpconfigs.