Conversation
… warnings Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/45b160b5-1bd3-4df9-9297-0993e67e3e27 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
frankslin
April 15, 2026 06:29
View session
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All build warnings originated from
deps/rapidjson-1.1.0/rapidjson/document.h(deprecatedstd::iteratorandmemcpyon non-trivially-copyable types), triggered bysrc/Config.cppincluding it. The warnings were artifacts of the vendored library's age against C++17, not OpenCC code.Change
In
src/CMakeLists.txt, mark alldeps/include directories with CMake'sSYSTEMkeyword:Applied to
rapidjson,marisa,tclap, anddarts-clone. TheSYSTEMflag causes the compiler to use-isysteminstead of-I, which suppresses diagnostics from those headers on GCC, Clang, and MSVC — the standard CMake mechanism for silencing third-party warnings without touching dep sources or broad project-level flag suppression.