Skip to content

Add 奥巴马 ↔ 歐巴馬 conversion to s2twp/tw2sp#1117

Merged
frankslin merged 1 commit intomasterfrom
copilot/add-obama-translation
Apr 16, 2026
Merged

Add 奥巴马 ↔ 歐巴馬 conversion to s2twp/tw2sp#1117
frankslin merged 1 commit intomasterfrom
copilot/add-obama-translation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

Taiwan uses 歐巴馬 for Obama while mainland uses 奥巴马; this pair was missing from the s2twp/tw2sp regional phrase conversion.

Dictionary changes

  • TWPhrases.txt: 奧巴馬 → 歐巴馬 — applied after ST conversion yields standard traditional form
  • TWPhrasesRev.txt: 歐巴馬 → 奧巴馬 — maps Taiwan form back to standard traditional before TS converts to simplified

Test cases

Added obama_s2twp and obama_tw2sp to testcases.json:

  • s2t/s2tw: 奥巴马 → 奧巴馬 (standard traditional, no Taiwan override)
  • s2twp: 奥巴马 → 歐巴馬
  • tw2sp: 歐巴馬 → 奥巴马

@frankslin frankslin marked this pull request as ready for review April 16, 2026 15:11
@frankslin frankslin mentioned this pull request Apr 16, 2026
@frankslin frankslin merged commit 856f743 into master Apr 16, 2026
33 of 34 checks passed
@frankslin frankslin deleted the copilot/add-obama-translation branch April 16, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants