Add measured CLI timings and richer benchmark variants#1130
Merged
frankslin merged 3 commits intoBYVoid:masterfrom Apr 20, 2026
Merged
Add measured CLI timings and richer benchmark variants#1130frankslin merged 3 commits intoBYVoid:masterfrom
frankslin merged 3 commits intoBYVoid:masterfrom
Conversation
Extend the benchmark binary to compare compiled ocd2 configs against temporary text-json variants without duplicating committed config files. The benchmark runner now rewrites config dictionaries to text inputs on the fly, registers grouped in-process and command-line benchmark families, and prints grouped console output with explicit throughput plus command-line stage breakdowns. Add --measured_result to the opencc command-line tool so end-to-end benchmark runs can record structured load/convert/write/total timing data as JSON. Cover the new option with a command-line test and make the benchmark target depend on the opencc executable so command-line benchmarks run reliably in the build tree.
Collaborator
Author
|
Example result: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28dfb5e98a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Use CMake's resolved opencc target path for command-line benchmarks so Windows multi-config generators launch the correct executable instead of hardcoding src/tools/opencc(.exe). Write generated benchmark config variants under the benchmark build directory instead of the source config directories, which keeps the source tree clean and allows read-only source checkouts to run the benchmark suite.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff79da9658
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Rewrite benchmark-generated segmentation resource paths so jieba text_json cases keep resolving cppjieba dictionary assets after configs move into the build tree. Wrap BM_CommandLine system commands with an outer quoted string on Windows, matching the command-line tests and avoiding cmd.exe path parsing failures when build paths contain spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the benchmark binary to compare compiled ocd2 configs against temporary text-json variants without duplicating committed config files. The benchmark runner now rewrites config dictionaries to text inputs on the fly, registers grouped in-process and command-line benchmark families, and prints grouped console output with explicit throughput plus command-line stage breakdowns.
Add --measured_result to the opencc command-line tool so end-to-end benchmark runs can record structured load/convert/write/total timing data as JSON. Cover the new option with a command-line test and make the benchmark target depend on the opencc executable so command-line benchmarks run reliably in the build tree.