feat(node): make jieba plugin a standalone and deterministic NPM package#1153
Merged
Conversation
This commit introduces a major architectural shift to allow the Jieba segmentation plugin to be distributed as an optional, standalone NPM package (`opencc-jieba`) without relying on global environment variables or requiring local C++ compilation. Key changes: - Core C++: Support `__plugin_library` key in JSON configuration to load a plugin directly from an absolute path, bypassing traditional directory searches. - Node Addon (`node/opencc.cc`): Add an overloaded constructor to `Opencc` accepting a raw JSON string and a base config directory. - Node API (`node/opencc.js`): Optionally load `opencc-jieba`. If available, dynamically patch the Jieba configuration JSON by replacing relative dict paths and the segmentation plugin path with absolute paths from the standalone package. - Packaging (`plugins/jieba/node`): Introduce `build.js` to cross-compile the Jieba plugin via Bazel and pack prebuilt binaries (`prebuilds/`) and dictionaries (`data/`) into the `opencc-jieba` NPM package for deterministic, zero-configuration installation. - Build system: Update `plugins/jieba/BUILD.bazel` to correctly strip debugging symbols from the plugin dynamic libraries in release mode to reduce package size.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f90b20fec6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…azel config This commit addresses two issues reported during review: 1. Excludes Windows from GNU strip linker flags (-Wl,-s) in plugins/jieba/BUILD.bazel to prevent MSVC linking errors. 2. Replaces POSIX-specific stderr redirection (2>/dev/null) with Node.js cross-platform stdio handling in build.js for cquery commands.
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a major architectural shift to allow the Jieba segmentation plugin to be distributed as an optional, standalone NPM package (
opencc-jieba) without relying on global environment variables or requiring local C++ compilation.Key changes:
__plugin_librarykey in JSON configuration to load a plugin directly from an absolute path, bypassing traditional directory searches.node/opencc.cc): Add an overloaded constructor toOpenccaccepting a raw JSON string and a base config directory.node/opencc.js): Optionally loadopencc-jieba. If available, dynamically patch the Jieba configuration JSON by replacing relative dict paths and the segmentation plugin path with absolute paths from the standalone package.plugins/jieba/node): Introducebuild.jsto cross-compile the Jieba plugin via Bazel and pack prebuilt binaries (prebuilds/) and dictionaries (data/) into theopencc-jiebaNPM package for deterministic, zero-configuration installation.plugins/jieba/BUILD.bazelto correctly strip debugging symbols from the plugin dynamic libraries in release mode to reduce package size.