Use rules_zig for Windows prebuild actions#1237
Merged
Merged
Conversation
Remote Linux builds execute the Windows prebuild genrules in a clean Bazel action environment, where a host-installed zig binary is not available on PATH. This caused //node:opencc_node_windows_zig to fail with zig: command not found under BuildBuddy remote execution. Add the BCR rules_zig module, register its Zig toolchains, and wire the Node and Jieba Windows prebuild genrules to the resolved Zig toolchain via $(ZIG_BIN). This keeps the existing shell scripts reusable while making the Zig executable a declared Bazel toolchain input. Use Zig 0.15.2 because rules_zig 0.14.0 bundled version index exposes 0.15.2 and 0.16.0, not 0.14.1. Bump rules_cc to 0.2.18 to match the version selected by rules_zig and avoid a Bzlmod direct-dependency mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote Linux builds execute the Windows prebuild genrules in a clean Bazel action environment, where a host-installed zig binary is not available on PATH. This caused //node:opencc_node_windows_zig to fail with zig: command not found under BuildBuddy remote execution.
Add the BCR rules_zig module, register its Zig toolchains, and wire the Node and Jieba Windows prebuild genrules to the resolved Zig toolchain via $(ZIG_BIN). This keeps the existing shell scripts reusable while making the Zig executable a declared Bazel toolchain input.
Use Zig 0.15.2 because rules_zig 0.14.0 bundled version index exposes 0.15.2 and 0.16.0, not 0.14.1. Bump rules_cc to 0.2.18 to match the version selected by rules_zig and avoid a Bzlmod direct-dependency mismatch.