Skip to content

Remove redundant errorCallback from onClose #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bghgary merged 3 commits into from
Apr 10, 2026
Merged

Remove redundant errorCallback from onClose #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3128739
Fix double errorCallback on WebSocket error + close
bghgary Apr 9, 2026
71a7237
Address review: AtomicBoolean + reset on reconnect
bghgary Apr 9, 2026
23dd248
Remove redundant errorCallback from onClose
bghgary Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Dependencies/WebSocket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import org.java_websocket.client.WebSocketClient;
import org.java_websocket.handshake.ServerHandshake;
import org.java_websocket.framing.CloseFrame;
import java.net.URI;
import java.net.URISyntaxException;

Expand All @@ -25,12 +24,6 @@ public void onMessage(String message)
@Override
public void onClose(int code, String reason, boolean remote)
{
// For all other close frames, we need to trigger the error callback
if (code != CloseFrame.NORMAL && code != CloseFrame.ABNORMAL_CLOSE && code != CloseFrame.NEVER_CONNECTED)
{
this.errorCallback(reason);
}

this.closeCallback(code, reason);
}

Expand Down