Skip to content

Add skinned mesh reference when loading glTF skins #12506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

Add skinned mesh reference when loading glTF skins #12506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/dev/loaders/src/glTF/2.0/glTFLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,8 +798,17 @@ export class GLTFLoader implements IGLTFLoader {
const mesh = ArrayItem.Get(`${context}/mesh`, this._gltf.meshes, node.mesh);
promises.push(
this._loadMeshAsync(`/meshes/${mesh.index}`, node, mesh, (babylonTransformNode) => {
const babylonTransformNodeForSkin = node._babylonTransformNodeForSkin!;

// Duplicate the metadata from the skin node to the skinned mesh in case any loader extension added metadata.
babylonTransformNode.metadata = node._babylonTransformNodeForSkin!.metadata;
babylonTransformNode.metadata = babylonTransformNodeForSkin.metadata;

// Add a reference to the skinned mesh from the transform node.
babylonTransformNodeForSkin.metadata.gltf.skinnedMesh = babylonTransformNode;
babylonTransformNode.onDisposeObservable.addOnce(() => {
// Delete the reference when the skinned mesh is disposed.
delete babylonTransformNodeForSkin.metadata.gltf.skinnedMesh;
});

const skin = ArrayItem.Get(`${context}/skin`, this._gltf.skins, node.skin);
promises.push(
Expand Down