[FloatingOrigin] Web GPU Fix #17356
[FloatingOrigin] Web GPU Fix #17356
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17356/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17356/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17356/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
4 participants
in FloatingOriginMode, we override effect.setMatrix to apply an offset. This in turn calls pipelineContext.setMatrix, which in webGPUPipelineContext will call ubo.updateMatrix
previously, this would apply offset again and cause incorrect positioning. The fix is to avoid double offset by existing early if the passed in matrix is === the most recently offset Temp matrix. To avoid cases where TempFinalMat happens to be equal values, I also move the updateFlag set to after the early out check.