Fixed using instanced VAT in ShaderMaterial #17462
Merged
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue https://forum.babylonjs.com/t/missing-doc-for-gpupicker-in-v8-31-3/61295/8
I noticed that
PrepareAttributesForBakedVertexAnimationdoes not function correctly inShaderMaterial. The reason is as follows:https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Materials/materialHelper.functions.ts#L415
PrepareAttributesForBakedVertexAnimationchecks whetherBAKED_VERTEX_ANIMATION_TEXTUREandINSTANCESexist in the defines to determine whether to add thebakedVertexAnimationSettingsInstancedattribute to the list.However,
ShaderMaterialstores the define list as a sequence of“#define DEFINENAME”entries, causing it to fail this test.Therefore, I specialized this logic to suit
ShaderMaterial.This approach was chosen based on the observation that specialization had already been performed in the logic for assigning Bone's Define and Attribute within
ShaderMaterial.