Skip to content

Fix submesh recreation when it should not #7889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix submesh recreation when it should not #7889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dist/preview release/what's new.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,6 @@
- Fix texture being inverted on the Y axis by default when using TextureAsset or AssetManager ([broederj](https://github.com/broederj))
- Fix `TexturePacker` cross-origin image requests, fix falsy default options ([ludevik](https://github.com/ludevik))

- Fix submesh recreation when it should not ([Popov72](https://github.com/Popov72)

## Breaking changes
4 changes: 2 additions & 2 deletions src/Meshes/mesh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,12 +1113,12 @@ export class Mesh extends AbstractMesh implements IGetSetVerticesData {
needToRecreate = true;
} else {
for (var submesh of this.subMeshes) {
if (submesh.indexStart + submesh.indexCount >= totalIndices) {
if (submesh.indexStart + submesh.indexCount > totalIndices) {
needToRecreate = true;
break;
}

if (submesh.verticesStart + submesh.verticesCount >= totalVertices) {
if (submesh.verticesStart + submesh.verticesCount > totalVertices) {
needToRecreate = true;
break;
}
Expand Down