Skip to content

Fix issue in mesh.MergeMeshes where mesh overriden side orientation is not propagated. #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Fix issue in mesh.MergeMeshes where mesh overriden side orientation is not propagated. #7915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0933ff
Fix issue in merge meshes where mesh overridden material side orienta…
Drigax Mar 26, 2020
7c87c11
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
Drigax Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/preview release/what's new.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
- Fix submesh recreation when it should not ([Popov72](https://github.com/Popov72)
- Fix `CustomMaterial` and `PBRCustomMaterial` not setting uniforms / samplers / attributes ([Popov72](https://github.com/Popov72)
- Fix bug in NME where deleting a node from a frame would not remove its ports on the outside of a frame
- Fix mesh winding order inversion when merging meshes with overridden side orientation ([drigax](https://github.com/Drigax))

## Breaking changes

Expand Down
1 change: 1 addition & 0 deletions src/Meshes/mesh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4114,6 +4114,7 @@ export class Mesh extends AbstractMesh implements IGetSetVerticesData {

// Setting properties
meshSubclass.checkCollisions = source.checkCollisions;
meshSubclass.overrideMaterialSideOrientation = source.overrideMaterialSideOrientation;

// Cleaning
if (disposeSource) {
Expand Down