Skip to content

Fix error not display when creating a CSM in WebGL1 #8921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RaananW merged 1 commit into from
Sep 10, 2020
Merged

Fix error not display when creating a CSM in WebGL1 #8921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Lights/Shadows/cascadedShadowGenerator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,13 +715,13 @@ export class CascadedShadowGenerator extends ShadowGenerator {
* @param usefulFloatFirst By default the generator will try to use half float textures but if you need precision (for self shadowing for instance), you can use this option to enforce full float texture.
*/
constructor(mapSize: number, light: DirectionalLight, usefulFloatFirst?: boolean) {
super(mapSize, light, usefulFloatFirst);

if (!CascadedShadowGenerator.IsSupported) {
Logger.Error("CascadedShadowMap needs WebGL 2 support.");
return;
}

super(mapSize, light, usefulFloatFirst);

this.usePercentageCloserFiltering = true;
}

Expand Down