Fix to make updateSize work, at least in one way, across platforms#154
Closed
syntheticmagus wants to merge 1 commit intoBabylonJS:masterfrom
Closed
Fix to make updateSize work, at least in one way, across platforms#154syntheticmagus wants to merge 1 commit intoBabylonJS:masterfrom
syntheticmagus wants to merge 1 commit intoBabylonJS:masterfrom
Conversation
Contributor
Author
|
Abandoning, will just use #define instead. |
bghgary
added a commit
that referenced
this pull request
Apr 14, 2026
[Created by Copilot on behalf of @bghgary] Bump JsRuntimeHost, arcana.cpp, and AndroidExtensions to latest. ## JsRuntimeHost (8086014) - **#147**: Fix WorkQueue destructor deadlock (cancel + no-op wake) - **#149**: Merge WorkQueue into AppRuntime (eliminates split-lifetime issues) - **#150**: Fix WebSocket test flake + update UrlLib/AndroidExtensions for consistent onClose-after-onError - **#151**: Clean up deadlock regression test (one-shot hook, expanded comments) - **#152**: Fix performance test flake (remove upper-bound setTimeout assertion) - **#154**: Hide arcana behind pimpl pattern in AppRuntime (arcana headers no longer exposed publicly) - **#155**: Update package-lock.json ## arcana.cpp (b9bf9d8) Includes test hooks for the deadlock regression test (`ARCANA_TEST_HOOKS` / `arcana::test_hooks::blocking_concurrent_queue`). ## AndroidExtensions (2e85a8d) Removes the redundant `errorCallback` from `onClose` in the Java WebSocket wrapper (AndroidExtensions#16). Matches the version JsRuntimeHost depends on via UrlLib. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.