UWP Validation Tests#697
Merged
Merged
Conversation
* nightly github action * syntax error * more * msbuild * wget babylon.max.js
CedricGuillemet
requested review from
Drigax,
bghgary,
chrisfromwork,
ryantrem and
syntheticmagus
…nto uwpVT # Conflicts: # Apps/ValidationTests/CMakeLists.txt # Apps/ValidationTests/Shared/TestUtils.h
…tive into uwpVT # Conflicts: # .github/workflows/nightly.yml # Apps/ValidationTests/Scripts/validation_native.js # README.md
…nto uwpVT # Conflicts: # Apps/ValidationTests/CMakeLists.txt # Apps/ValidationTests/Shared/TestUtils.h
bghgary
reviewed
Jun 18, 2021
Comment on lines
+33
to
+44
| std::string WStringToString(const wchar_t* w, size_t size) | ||
| { | ||
| auto length{ ::WideCharToMultiByte(CP_UTF8, 0, w,static_cast<int>(size), nullptr, 0, nullptr, nullptr) }; | ||
|
|
||
| std::string ret{}; | ||
| if (length) | ||
| { | ||
| ret.resize(length); | ||
| ::WideCharToMultiByte(CP_UTF8, 0, w, static_cast<int>(size), &ret[0], length, nullptr, nullptr); | ||
| } | ||
| return ret; | ||
| } |
| target_compile_options(ValidationTests PRIVATE /await) | ||
| endif() | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
nit: extra line
Suggested change
syntheticmagus
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UWP Validation Test App. To run locally until it's automated with the CI.