Add uwp packaging logic #142
Conversation
Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
chrisfromwork
requested review from
bghgary,
rgerd,
rickfromwork,
ryantrem,
satyapoojasama and
tymlipari
| resolver: { | ||
| blockList: exclusionList([ | ||
| // This stops "react-native run-windows" from causing the metro server to crash if its already running | ||
| new RegExp( | ||
| `${path.resolve(__dirname, 'windows').replace(/[/\\]/g, '/')}.*`, | ||
| ), | ||
| // This prevents "react-native run-windows" from hitting: EBUSY: resource busy or locked, open msbuild.ProjectImports.zip | ||
| /.*\.ProjectImports\.zip/, | ||
| ]), | ||
| }, |
There was a problem hiding this comment.
So at this point, any consumer of the NPM package will additionally need to make these changes to their metro.config.js?
There was a problem hiding this comment.
react-native-windows on setup overwrites this file to contain this logic, and when other custom things are in this file it doesn't seem to merge them. If there are thoughts on how things could be improved, we should relay this feedback to the react-native-windows team.
There was a problem hiding this comment.
Yea that's pretty bad. I guess their assumption is that people will diff the file and manually fix it up. One thing that would help would be to put this logic in a separate file that is bundled with RNW and import it into this file. That might be good feedback for the rnw folks.
| "logkitty": "^0.7.1", | ||
| "react": "^17.0.1", | ||
| "react-native": "^0.64.0-rc.0", | ||
| "react-native": "0.64.0-rc.0", |
There was a problem hiding this comment.
when running react-native-windows initialization, react-native-windows will prompt/force users to use newer preview releases that support whatever react-native release is in the project. I don't think we are guaranteed that react-native-windows preview releases won't contain breaking changes (I have seen breaking changes already).
What I was seeing was that react-native would get installed at 0.64.0-rc.2, forcing us to update to react-native-windows 0.64.0-preview.7 which contained breaking changes for native modules (This was all during initialization prompts compared to an action of npm package installs). I believe we can ensure things will compile if we don't auto update to newer versions of react-native/react-native-windows. I think this will probably get better when react-native-windows has a formal 0.64.0 release.
|
Regarding this comment in your PR description:
Autolinking makes the |
2 participants
This review adds uwp packaging logic to the pre-existing android/ios NPM package. It contains the following: