Support for POST requests and setting request headers#12
Merged
Conversation
bghgary
reviewed
Mar 6, 2023
Contributor
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
First pass. Will review again after updates.
Contributor
|
PR title could be updated here too :-) |
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
lmaskati
changed the title
bghgary
reviewed
Mar 8, 2023
Contributor
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
Some small things. Looking good otherwise.
bghgary
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a draft until BabylonJS/UrlLib#1 is merged, after which it needs to be tested with an updated CMake.