Skip to content

Update to Babylon fork of v8 binary for Android #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryantrem merged 6 commits into from
Jan 26, 2026
Merged

Update to Babylon fork of v8 binary for Android #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02e0aa1
Hardcode local package path
ryantrem Jan 23, 2026
e5fd40b
Switch to mac
ryantrem Jan 23, 2026
b90a397
Update path in cmakelists
ryantrem Jan 23, 2026
ae7ce50
Required code changes for newer v8
ryantrem Jan 24, 2026
b296fd8
Switch to published version
ryantrem Jan 24, 2026
90e42ae
Don't enable sandbox for Android (the Android binary does not have sa…
ryantrem Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/AppRuntime/V8Inspector/Include/V8Inc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#ifndef V8_31BIT_SMIS_ON_64BIT_ARCH
#define V8_31BIT_SMIS_ON_64BIT_ARCH 1
#endif
#ifndef V8_ENABLE_SANDBOX
#if !defined(ANDROID) && !defined(V8_ENABLE_SANDBOX)
#define V8_ENABLE_SANDBOX 1
#endif
#endif
Expand Down
9 changes: 1 addition & 8 deletions Core/AppRuntime/V8Inspector/Source/V8InspectorAgent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,7 @@ namespace Babylon

void ConnectFrontend()
{
session_ = inspector_->connect(
1, new ChannelImpl(agent_), v8_inspector::StringView()
// v8-android package and v8 nuget do not share the same V8 version. A change in V8_inspector API forces us to add this
// ifndef check. This will be fixed in a future nuget package update.
#ifndef ANDROID
, v8_inspector::V8Inspector::kFullyTrusted
#endif
);
session_ = inspector_->connect(1, new ChannelImpl(agent_), v8_inspector::StringView(), v8_inspector::V8Inspector::kFullyTrusted);
}

void DisconnectFrontend()
Expand Down
5 changes: 3 additions & 2 deletions Core/Node-API/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@ if(NAPI_BUILD_ABI)
"Source/js_native_api_v8_internals.h")

if(ANDROID)
set(V8_PACKAGE_NAME "v8-android-jit-nointl-nosnapshot")
set(V8_ANDROID_DIR "${CMAKE_CURRENT_BINARY_DIR}/${V8_PACKAGE_NAME}")
set(V8_PACKAGE_BASE_NAME "v8-android-jit-nointl-nosnapshot")
set(V8_PACKAGE_NAME "@babylonjs/${V8_PACKAGE_BASE_NAME}")
set(V8_ANDROID_DIR "${CMAKE_CURRENT_BINARY_DIR}/${V8_PACKAGE_BASE_NAME}")
napi_install_android_package(v8 "dist/org/chromium" ${V8_ANDROID_DIR})

set(INCLUDE_DIRECTORIES ${INCLUDE_DIRECTORIES}
Expand Down
2 changes: 1 addition & 1 deletion Core/Node-API/Include/Engine/V8/napi/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#ifndef V8_31BIT_SMIS_ON_64BIT_ARCH
#define V8_31BIT_SMIS_ON_64BIT_ARCH 1
#endif
#ifndef V8_ENABLE_SANDBOX
#if !defined(ANDROID) && !defined(V8_ENABLE_SANDBOX)
#define V8_ENABLE_SANDBOX 1
#endif
#endif
Expand Down
2 changes: 1 addition & 1 deletion Core/Node-API/Source/js_native_api_v8_internals.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#ifndef V8_31BIT_SMIS_ON_64BIT_ARCH
#define V8_31BIT_SMIS_ON_64BIT_ARCH 1
#endif
#ifndef V8_ENABLE_SANDBOX
#if !defined(ANDROID) && !defined(V8_ENABLE_SANDBOX)
#define V8_ENABLE_SANDBOX 1
#endif
#endif
Expand Down
2 changes: 1 addition & 1 deletion Core/Node-API/package-v8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"dependencies": {
"v8-android-jit-nointl-nosnapshot": "11.1000.4"
"@babylonjs/v8-android-jit-nointl-nosnapshot": "11.110.1"
}
}