Build fixes#135
Merged
bghgary merged 1 commit intoBabylonJS:mainfrom Feb 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates pinned dependency revisions and adjusts the Apple-unit-test CMake target to enable Objective-C ARC via a shared helper rather than an iOS-only Xcode attribute.
Changes:
- Bumped the pinned
FetchContentcommit hashes forAndroidExtensions,CMakeExtensions, andUrlLib. - Enabled Objective-C ARC for the
UnitTeststarget on all Apple platforms viaenable_objc_arc(UnitTests). - Removed the redundant iOS-only
XCODE_ATTRIBUTE_CLANG_ENABLE_OBJC_ARCtarget property.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Tests/UnitTests/CMakeLists.txt |
Enables ARC for the UnitTests target on Apple platforms and removes the iOS-specific Xcode ARC attribute. |
CMakeLists.txt |
Updates pinned dependency commit hashes for AndroidExtensions, CMakeExtensions, and UrlLib. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bkaradzic-microsoft
approved these changes
Feb 12, 2026
CedricGuillemet
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies to newer versions and improves Objective-C ARC handling for unit tests on Apple platforms. The most important changes are grouped below.
Dependency Updates:
AndroidExtensionssubmodule to use a newer commit hash, ensuring the latest features and fixes are included.CMakeExtensionssubmodule to a newer commit hash for improved build system capabilities.UrlLibsubmodule to a newer commit hash, likely for bug fixes or enhancements.Apple Platform Build Improvements:
enable_objc_arc(UnitTests)for Apple platforms, improving Objective-C ARC handling and removing the redundantXCODE_ATTRIBUTE_CLANG_ENABLE_OBJC_ARCproperty for iOS builds.