Skip to content

Build fixes#135

Merged
bghgary merged 1 commit intoBabylonJS:mainfrom
bghgary:build-fixes
Feb 12, 2026
Merged

Build fixes#135
bghgary merged 1 commit intoBabylonJS:mainfrom
bghgary:build-fixes

Conversation

@bghgary
Copy link
Copy Markdown
Contributor

@bghgary bghgary commented Feb 11, 2026

This pull request updates several dependencies to newer versions and improves Objective-C ARC handling for unit tests on Apple platforms. The most important changes are grouped below.

Dependency Updates:

  • Updated the AndroidExtensions submodule to use a newer commit hash, ensuring the latest features and fixes are included.
  • Updated the CMakeExtensions submodule to a newer commit hash for improved build system capabilities.
  • Updated the UrlLib submodule to a newer commit hash, likely for bug fixes or enhancements.

Apple Platform Build Improvements:

  • Added a conditional call to enable_objc_arc(UnitTests) for Apple platforms, improving Objective-C ARC handling and removing the redundant XCODE_ATTRIBUTE_CLANG_ENABLE_OBJC_ARC property for iOS builds.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates pinned dependency revisions and adjusts the Apple-unit-test CMake target to enable Objective-C ARC via a shared helper rather than an iOS-only Xcode attribute.

Changes:

  • Bumped the pinned FetchContent commit hashes for AndroidExtensions, CMakeExtensions, and UrlLib.
  • Enabled Objective-C ARC for the UnitTests target on all Apple platforms via enable_objc_arc(UnitTests).
  • Removed the redundant iOS-only XCODE_ATTRIBUTE_CLANG_ENABLE_OBJC_ARC target property.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Tests/UnitTests/CMakeLists.txt Enables ARC for the UnitTests target on Apple platforms and removes the iOS-specific Xcode ARC attribute.
CMakeLists.txt Updates pinned dependency commit hashes for AndroidExtensions, CMakeExtensions, and UrlLib.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bghgary bghgary merged commit fec7975 into BabylonJS:main Feb 12, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants