Add parameters to error and close callbacks#28
Merged
Conversation
bghgary
reviewed
May 15, 2023
bghgary
reviewed
May 15, 2023
bghgary
approved these changes
May 17, 2023
bkaradzic-microsoft
added a commit
to bkaradzic-microsoft/JsRuntimeHost
that referenced
this pull request
May 14, 2026
Picks up: - UrlLib BabylonJS#28: client-side-failure fixes (Unix worker thread no longer terminates on missing local files; Apple Open no longer throws synchronously on missing app:/// paths) plus per-request response state reset hoisted to ImplBase::ResetForOpen(). - UrlLib BabylonJS#29: UWP build fix (guard the new m_fileResponseBuffer.clear() call with WINAPI_PARTITION_DESKTOP). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
added a commit
that referenced
this pull request
May 14, 2026
Picks up [UrlLib #28](BabylonJS/UrlLib#28) so consumers (including BabylonNative) get the client-side-failure fixes: - `ImplBase::ResetForOpen()` clears `m_statusCode`, `m_responseUrl`, `m_responseString`, `m_headers` between `Open()` calls on all 5 platforms (Win32, UWP, Unix, Apple, Android). - Unix `PerformAsync` no longer lets `curl_check` exceptions escape `std::thread` -> `std::terminate`; falls back to `status=0 + loadend` like Win32/UWP. - Apple `Open` no longer throws synchronously when `[NSBundle pathForResource:]` returns nil for missing local files; sets `m_url = nil` and lets the existing `SendAsync` branch return `status=0`. This is a pin-bump only: no source changes in JsRuntimeHost itself. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.