fix capture for float type framebuffers#276
Merged
sebavan merged 1 commit intoBabylonJS:masterfrom Aug 23, 2023
Merged
Conversation
sebavan
requested changes
Aug 16, 2023
Member
sebavan
left a comment
sebavan
left a comment
There was a problem hiding this comment.
thanks for the fix, can you revert the changes within the js files and only keep the ts one ?
Inuniku
force-pushed
the
fix/get-capture-for-float-framebuffer
branch
from
e02551b to
9aef187
Compare
Author
|
oh, okay! |
sebavan
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framebuffers of float type generate this warning:
And therefore generate no preview:
