Standardize error handling, improve validation, and refine UI behavior#3
Merged
Standardize error handling, improve validation, and refine UI behavior#3
Conversation
Refactored error messages across the application to use the ERROR_MESSAGES constant from config/constants.ts. This improves consistency and maintainability of error handling in LandingPage, mediaService, peerService, and usePasswordVerification.
Replaces external Hubot Sans font with locally hosted font files and updates styles to use them. Enhances password input validation with min/max length checks and user feedback, updating related constants and error messages. Also updates react-router-dom and vite dependencies to latest major versions.
Standardized error messages by adding SESSION_ENDED to constants and using it in ParticipantPage. Updated LandingPage to use ERROR_MESSAGES.UNABLE_TO_CONNECT for consistency. Improved navigation on session end to clear query parameters.
Appends 'controls-overlay--visible' class to the controls overlay div when the QR panel is displayed, enabling conditional styling based on QR panel visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves consistency and maintainability across the application.
Error handling has been standardized by centralizing messages into shared constants and unifying session end behavior. Password validation was enhanced with clearer length checks and user feedback, and related messages were updated accordingly.
The Hubot Sans font is now locally hosted to reduce external dependencies. UI behavior was also refined by applying a visible state to the controls overlay when the QR panel is shown.
Additionally, react-router-dom and Vite were upgraded to their latest major versions to keep dependencies up to date.