fix: duplicated discriminator serialisation issue#1220
Merged
Conversation
YuriiBatkovych
changed the title
YuriiBatkovych
force-pushed
the
fix/dublicated-discriminator-issue
branch
from
a332607 to
9819d31
Compare
YuriiBatkovych
changed the title
jjjasper
force-pushed
the
fix/dublicated-discriminator-issue
branch
from
e017b83 to
2da0757
Compare
|
jjjasper
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses OpenAPI-Generator Issue #3796, where the discriminator property is serialized twice in Java Jackson projects.
The Problem
When using a discriminator with Jackson, the generator currently includes
allowGetters = truewithin the@JsonIgnorePropertiesannotation. This configuration inadvertently tells Jackson that even though the property is "ignored," it is still allowed to be accessed via its getter during the serialization process.Because
@JsonTypeInfois also configured to include the discriminator (via visible = true and include = JsonTypeInfo.As.PROPERTY), Jackson ends up writing the field twice:The Fix
We have modified
typeInfoAnnotation.mustacheto removeallowGetters = true.Removal of
allowGetters = true: This ensures that Jackson ignores the manual getter during serialization, preventing the duplicate field.Retention of
allowSetters = true: This remains necessary to ensure that the discriminator can still be mapped to the class field during deserialization.