Feature: maven artifact input for generate and lint goals #197
Conversation
sophiejanssens
requested review from
bartveenstra,
bballie,
bbzurek,
christopherm-backbase,
fredysierra,
pa314159 and
psplinakis
bartveenstra
left a comment
bartveenstra
left a comment
There was a problem hiding this comment.
The example contains backbase specfic examples. such as the bom file. Please use the bom file that is already in the examples.
bartveenstra
left a comment
bartveenstra
left a comment
There was a problem hiding this comment.
Plus code coverage must be on par :)
| @@ -0,0 +1,82 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
You must not refer to internal artifacts or specs
| <modules> | ||
| <module>angular</module> | ||
| <module>java-clients</module> | ||
| <!-- <module>java-clients</module>--> |
There was a problem hiding this comment.
Sorry that was accident
| <goal>doc</goal> | ||
| </goals> | ||
| <configuration> | ||
| <inputSpec>${project.basedir}/src/main/resources/contact-manager_contact-manager-service-api-v2.3.0.yaml</inputSpec> |
There was a problem hiding this comment.
this is an internal API and cannot be used
| for (File f : inputSpecs) { | ||
| inputSpec = f.getPath(); | ||
| output = new File(outPutDirectory.getPath(),f.getName().substring(0,f.getName().lastIndexOf(".")).concat("-docs")); | ||
| output = new File(outPutDirectory.getPath(), f.getName().substring(0, f.getName().lastIndexOf(".")).concat("-docs")); |
There was a problem hiding this comment.
Output are always docs? Also for client generation?
There was a problem hiding this comment.
The directory input was only wanted for doc goal
There was a problem hiding this comment.
I can change it for others if wanted
There was a problem hiding this comment.
Ah! I see that now! Sorry. Disregard the previous comment :)
|
Kudos, SonarCloud Quality Gate passed! |
|
@pa314159 Can you also review this? |
No description provided.