Improve the error message. #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjjasper
requested review from
BB-DDeChristofaro,
bartveenstra,
pa314159,
sophiejanssens and
torrespro
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
bartveenstra
left a comment
bartveenstra
left a comment
There was a problem hiding this comment.
Is this allowed? 1.0.0-alpha
BB-DDeChristofaro
approved these changes
Nov 15, 2021
BB-DDeChristofaro
left a comment
BB-DDeChristofaro
left a comment
There was a problem hiding this comment.
I like the new error message! Thank you!
Collaborator
Author
The code validates the version number only to the extend of being able to deduct what is the major so it can compare that it matches the version in the filename. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #242
Improve the error message when the api version in the file cannot be parsed.