Skip to content

BoatAngularGenerator: add dependency versions for ang@13#298

Merged
santam85 merged 4 commits intomainfrom
bugfix/support-ang-13-deps
Aug 9, 2022
Merged

BoatAngularGenerator: add dependency versions for ang@13#298
santam85 merged 4 commits intomainfrom
bugfix/support-ang-13-deps

Conversation

@brianvabb
Copy link
Copy Markdown
Contributor

@brianvabb brianvabb commented Aug 5, 2022

Description

BoatAngularGenerator: add dependency versions to support angular@13. The compatible peer dependency versions were found in the following resources:

Fixes # nojira

Type of change

  • Versions (update of Angular dependency versions)

@brianvabb
Copy link
Copy Markdown
Contributor Author

brianvabb commented Aug 5, 2022

  • Needs review before merge.

@ngohungphuc
Copy link
Copy Markdown
Contributor

@brianvabb what about zonejs version ? I think we should use 0.11.4

image

@santam85
Copy link
Copy Markdown
Contributor

santam85 commented Aug 8, 2022

  • fix code smells

Copy link
Copy Markdown
Contributor

@daiscog daiscog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is zonejsVersion needed at all? It doesn't appear in the generated peerDependencies. I guess it's implied via the Angular dependency:

  "peerDependencies": {
    "@angular/core": ">=11.0.0",
    "@backbase/foundation-ang": ">=6.15.1",
    "rxjs": ">=6.6.0"
  },

@ngohungphuc ngohungphuc force-pushed the bugfix/support-ang-13-deps branch 3 times, most recently from 93b3181 to 52e738b Compare August 8, 2022 14:33
@ngohungphuc
Copy link
Copy Markdown
Contributor

ngohungphuc commented Aug 9, 2022

@santam85 @daiscog Fixed the build. Please check it again then I will merge it.
Thank you

image

@ngohungphuc ngohungphuc force-pushed the bugfix/support-ang-13-deps branch from d02fcc9 to f635bf8 Compare August 9, 2022 12:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@santam85 santam85 merged commit fbb2ccb into main Aug 9, 2022
@santam85 santam85 deleted the bugfix/support-ang-13-deps branch May 4, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants