BoatAngularGenerator: add dependency versions for ang@13#298
Merged
Conversation
Contributor
Author
|
santam85
approved these changes
Aug 5, 2022
Contributor
|
@brianvabb what about zonejs version ? I think we should use 0.11.4 |
ngohungphuc
reviewed
Aug 8, 2022
Contributor
|
daiscog
approved these changes
Aug 8, 2022
Contributor
daiscog
left a comment
There was a problem hiding this comment.
Is zonejsVersion needed at all? It doesn't appear in the generated peerDependencies. I guess it's implied via the Angular dependency:
"peerDependencies": {
"@angular/core": ">=11.0.0",
"@backbase/foundation-ang": ">=6.15.1",
"rxjs": ">=6.6.0"
},
93b3181 to
52e738b
Compare
Contributor
d02fcc9 to
f635bf8
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ngohungphuc
approved these changes
Aug 9, 2022
daiscog
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










Description
BoatAngularGenerator: add dependency versions to support
angular@13. The compatible peer dependency versions were found in the following resources:Fixes # nojira
Type of change