Skip to content

[BUS-504]: notation for createMocks to enable tree-shaking#458

Merged
santam85 merged 4 commits intomainfrom
bugfix/BUS-504-frontend-business-app-do-not-include-mock-data-in-the-production-build
Jan 27, 2023
Merged

[BUS-504]: notation for createMocks to enable tree-shaking#458
santam85 merged 4 commits intomainfrom
bugfix/BUS-504-frontend-business-app-do-not-include-mock-data-in-the-production-build

Conversation

@skellig-s
Copy link
Copy Markdown
Contributor

No description provided.

@santam85
Copy link
Copy Markdown
Contributor

Looks like BoatAngularTemplateTests needs updating

@skellig-s
Copy link
Copy Markdown
Contributor Author

Tests are updated

Copy link
Copy Markdown
Contributor

@cheshirsky cheshirsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skellig-s, we need to make sure we have it published with a correct version, so that we can use it right away, i.e. it should be 0.16.x, not 0.17.x version

@skellig-s
Copy link
Copy Markdown
Contributor Author

skellig-s commented Jan 27, 2023

Contribution rules have these two phrases:

  • Make sure you update the release notes in the README.md file.
  • Release notes for those are generated automatically from the merged PRs descriptions, and a new release draft is created at every release event.

Which one is correct? Should I manually update the release notes or is it done automatically?

@santam85
Copy link
Copy Markdown
Contributor

The readme must be updated, the version that will be released is the one contained in the pom.xml (as a snapshot).
I'll correct the contribution guidelines.

@skellig-s
Copy link
Copy Markdown
Contributor Author

Changelog updated

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
12.5% 12.5% Duplication

@santam85 santam85 merged commit 58ed59b into main Jan 27, 2023
@santam85 santam85 deleted the bugfix/BUS-504-frontend-business-app-do-not-include-mock-data-in-the-production-build branch January 27, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants