Conversation
Contributor
|
Looks like BoatAngularTemplateTests needs updating |
Contributor
Author
|
Tests are updated |
cheshirsky
approved these changes
Jan 27, 2023
cheshirsky
reviewed
Jan 27, 2023
Contributor
cheshirsky
left a comment
There was a problem hiding this comment.
@skellig-s, we need to make sure we have it published with a correct version, so that we can use it right away, i.e. it should be 0.16.x, not 0.17.x version
Contributor
Author
|
Contribution rules have these two phrases:
Which one is correct? Should I manually update the release notes or is it done automatically? |
Contributor
|
The readme must be updated, the version that will be released is the one contained in the pom.xml (as a snapshot). |
Contributor
Author
|
Changelog updated |
|
SonarCloud Quality Gate failed. |
santam85
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








No description provided.