Skip to content

DENG-92: Make contacts ingestion in streams sequential#588

Merged
Aboruhen merged 2 commits intomasterfrom
feat/DENG-92-Make-contacts-ingestion-in-streams-sequential
Apr 2, 2026
Merged

DENG-92: Make contacts ingestion in streams sequential#588
Aboruhen merged 2 commits intomasterfrom
feat/DENG-92-Make-contacts-ingestion-in-streams-sequential

Conversation

@Aboruhen
Copy link
Copy Markdown
Collaborator

@Aboruhen Aboruhen commented Mar 30, 2026

Description

Add a semaphore for checking a sequence.

Checklist

  • I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
  • I made sure to update CHANGELOG.md.
  • I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes).
  • My changes are adequately tested.
  • I made sure all the SonarCloud Quality Gate are passed.

Add semaphore for checking a sequence
@Aboruhen Aboruhen requested a review from a team as a code owner March 30, 2026 10:37
})
.doOnError(throwable -> {
if (throwable instanceof WebClientResponseException ex) {
log.warn("Execute contacts POST client failed (falling back to PATCH client): status={}, body={}",
Copy link
Copy Markdown

@pawelslowik pawelslowik Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aboruhen logs mention PATCH client fallback - is it valid? I can't see any fallback handling here.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a careful check

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

@Aboruhen Aboruhen merged commit 891e345 into master Apr 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants