Changes list of variants in variants.yml from array to dictionary#116
Merged
arthurpalves merged 4 commits intodevelopfrom Jan 22, 2021
Merged
Changes list of variants in variants.yml from array to dictionary#116arthurpalves merged 4 commits intodevelopfrom
variants.yml from array to dictionary#116arthurpalves merged 4 commits intodevelopfrom
Conversation
…]' and expose to public property 'variants' as array '[iOSVariant]'. this is required in order to easily modify variant properties in the YAML spec, such as 'version_name' and 'version_number'
… expose to public property 'variants' as array '[AndroidVariant]'. this is required in order to easily modify variant properties in the YAML spec, such as 'version_name' and 'version_number'
gderaco
approved these changes
Jan 22, 2021
Codecov Report
@@ Coverage Diff @@
## develop #116 +/- ##
===========================================
+ Coverage 61.61% 62.73% +1.12%
===========================================
Files 29 30 +1
Lines 1029 1060 +31
===========================================
+ Hits 634 665 +31
Misses 395 395
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
variants.ymlfrom array to dictionaryTask
resolves #114
Checklist:
make validationlocally with success