Skip to content

Changes list of variants in variants.yml from array to dictionary#116

Merged
arthurpalves merged 4 commits intodevelopfrom
refactor/114-array-to-dictionary
Jan 22, 2021
Merged

Changes list of variants in variants.yml from array to dictionary#116
arthurpalves merged 4 commits intodevelopfrom
refactor/114-array-to-dictionary

Conversation

@arthurpalves
Copy link
Copy Markdown
Member

What does this PR do

  • Changes list of variants in variants.yml from array to dictionary
  • Updates docs and resources accordingly

Task

resolves #114

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

…]' and expose to public property 'variants' as array '[iOSVariant]'. this is required in order to easily modify variant properties in the YAML spec, such as 'version_name' and 'version_number'
… expose to public property 'variants' as array '[AndroidVariant]'. this is required in order to easily modify variant properties in the YAML spec, such as 'version_name' and 'version_number'
@arthurpalves arthurpalves requested a review from gderaco January 22, 2021 15:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2021

Codecov Report

Merging #116 (9256ccb) into develop (eba7c3f) will increase coverage by 1.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
+ Coverage    61.61%   62.73%   +1.12%     
===========================================
  Files           29       30       +1     
  Lines         1029     1060      +31     
===========================================
+ Hits           634      665      +31     
  Misses         395      395              
Impacted Files Coverage Δ
.../VariantsCore/Schemas/Android/AndroidVariant.swift 95.65% <ø> (ø)
Sources/VariantsCore/Schemas/iOS/iOSVariant.swift 97.29% <ø> (ø)
...ntsCore/Schemas/Android/AndroidConfiguration.swift 100.00% <100.00%> (ø)
...es/VariantsCore/Schemas/iOS/iOSConfiguration.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba7c3f...bfc7ff9. Read the comment docs.

@arthurpalves arthurpalves merged commit 2bad20d into develop Jan 22, 2021
@arthurpalves arthurpalves deleted the refactor/114-array-to-dictionary branch January 22, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change variants from array to dictionary

2 participants