Skip to content

feat: automatically populate 'PROVISIONING_PROFILE_SPECIFIER' if using match in signing configuration#119

Merged
arthurpalves merged 2 commits intodevelopfrom
feat/117-match-prov-profile
Jan 26, 2021
Merged

feat: automatically populate 'PROVISIONING_PROFILE_SPECIFIER' if using match in signing configuration#119
arthurpalves merged 2 commits intodevelopfrom
feat/117-match-prov-profile

Conversation

@arthurpalves
Copy link
Copy Markdown
Member

What does this PR do

  • Automatically populate 'PROVISIONING_PROFILE_SPECIFIER' if using match in signing configuration

Task

resolves #117

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@arthurpalves arthurpalves requested a review from gderaco January 26, 2021 08:30
@backbaseoss
Copy link
Copy Markdown

Warnings
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 9bc3777

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2021

Codecov Report

Merging #119 (ad61c22) into develop (2bad20d) will decrease coverage by 0.28%.
The diff coverage is 37.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #119      +/-   ##
===========================================
- Coverage    62.73%   62.45%   -0.29%     
===========================================
  Files           30       30              
  Lines         1060     1084      +24     
===========================================
+ Hits           665      677      +12     
- Misses         395      407      +12     
Impacted Files Coverage Δ
...ces/VariantsCore/Factory/iOS/XCConfigFactory.swift 1.68% <0.00%> (-0.14%) ⬇️
...es/VariantsCore/Factory/iOS/XcodeProjFactory.swift 15.96% <0.00%> (ø)
Sources/VariantsCore/Schemas/iOS/iOSSigning.swift 58.53% <70.00%> (+3.69%) ⬆️
Sources/VariantsCore/Schemas/iOS/iOSVariant.swift 97.61% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d6d02...9bc3777. Read the comment docs.

@arthurpalves arthurpalves merged commit b126169 into develop Jan 26, 2021
@arthurpalves arthurpalves deleted the feat/117-match-prov-profile branch January 26, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS - Automatically populate 'PROVISIONING_PROFILE_SPECIFIER' if using Fastlane Match

2 participants