Fix variants setup for Android#133
Merged
arthurpalves merged 7 commits intodevelopfrom Mar 5, 2021
Merged
Conversation
…ting to fastlane parameter files
Generated by 🚫 Danger Swift against 7679f6d |
Codecov Report
@@ Coverage Diff @@
## develop #133 +/- ##
===========================================
- Coverage 62.90% 62.79% -0.11%
===========================================
Files 31 31
Lines 1170 1172 +2
===========================================
Hits 736 736
- Misses 434 436 +2
Continue to review full report at Codecov.
|
ghost
approved these changes
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
android.signingas optionalfastlane/in the base folder regardless of the path inandroid.pathRuntimeErrorwith more descriptive error message when writing to fastlane parameter filesHow can it be tested
variants initandroid.pathandroid.app_nameandroid.app_identifiervariants setupChecklist:
make validationlocally with success