Skip to content

Fix variants setup for Android#133

Merged
arthurpalves merged 7 commits intodevelopfrom
fix/android-setup
Mar 5, 2021
Merged

Fix variants setup for Android#133
arthurpalves merged 7 commits intodevelopfrom
fix/android-setup

Conversation

@arthurpalves
Copy link
Copy Markdown
Member

What does this PR do

  • Decodes android.signing as optional
  • Writes fastlane/ in the base folder regardless of the path in android.path
  • Throws RuntimeError with more descriptive error message when writing to fastlane parameter files
  • Removes redundant ❌ when instantiating RuntimeError

How can it be tested

  • Generate new spec with variants init
  • Replace the following placeholders with correct value:
    • android.path
    • android.app_name
    • android.app_identifier
  • Run variants setup

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@arthurpalves arthurpalves requested a review from a user March 5, 2021 10:46
@backbaseoss
Copy link
Copy Markdown

backbaseoss commented Mar 5, 2021

Warnings
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 7679f6d

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2021

Codecov Report

Merging #133 (e04b1a7) into develop (f4b59be) will decrease coverage by 0.10%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #133      +/-   ##
===========================================
- Coverage    62.90%   62.79%   -0.11%     
===========================================
  Files           31       31              
  Lines         1170     1172       +2     
===========================================
  Hits           736      736              
- Misses         434      436       +2     
Impacted Files Coverage Δ
.../VariantsCore/Custom Types/TemplateDirectory.swift 60.00% <0.00%> (ø)
...ces/VariantsCore/Custom Types/UtilsDirectory.swift 60.00% <0.00%> (ø)
...riantsCore/Factory/FastlaneParametersFactory.swift 28.37% <0.00%> (ø)
...antsCore/Custom Types/Project/AndroidProject.swift 85.58% <66.66%> (-1.58%) ⬇️
...ntsCore/Schemas/Android/AndroidConfiguration.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b59be...7679f6d. Read the comment docs.

@arthurpalves arthurpalves merged commit 22ecf79 into develop Mar 5, 2021
@arthurpalves arthurpalves deleted the fix/android-setup branch March 5, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants