Skip to content

Conversation

@GMinucci
Copy link
Collaborator

@GMinucci GMinucci commented Jan 7, 2022

What does this PR do

Update Github's CI workflow configuration file to use latest Xcode app.

Sidenote:

  1. The UnitTests were failing due to mkpath() in the test testFileWrite_correctOutput from FastlaneParametersFactoryTests. This was happening due to the method creating the complete path as a directory, resulting in the file being created as a directory.
  2. Small refactor in the AndroidProjectTests and iOSProjectTests classes to improve readability.

How can it be tested

This updates the CI config so no test is required as long as the CI is working.

Task

Fixes #160

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@GMinucci GMinucci added this to the Release 1.1.0 milestone Jan 7, 2022
@GMinucci GMinucci added the bug Something isn't working label Jan 7, 2022
@GMinucci GMinucci self-assigned this Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #161 (e564db4) into develop (26d3524) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #161   +/-   ##
========================================
  Coverage    58.36%   58.36%           
========================================
  Files           31       31           
  Lines         1172     1172           
  Branches       411      411           
========================================
  Hits           684      684           
  Misses         451      451           
  Partials        37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d3524...e564db4. Read the comment docs.

@gderaco gderaco merged commit 888378c into develop Mar 11, 2022
@gderaco gderaco deleted the chore/update-github-workflow-yml branch March 11, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants