-
Notifications
You must be signed in to change notification settings - Fork 7
Allow setting iOS Bundle id for Variant #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger Swift against 02ad852 |
Co-authored-by: obackbase <46746140+obackbase@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## develop #173 +/- ##
===========================================
+ Coverage 71.90% 72.46% +0.56%
===========================================
Files 36 36
Lines 1242 1264 +22
Branches 441 451 +10
===========================================
+ Hits 893 916 +23
+ Misses 309 308 -1
Partials 40 40
Continue to review full report at Codecov.
|
|
PR is approved by 2 people, yet it can't be merged because a build hasn't started, therefore cannot report its completion. |
What does this PR do
Allows user to set the BundleID for a specific variant.
Extra changes
How can it be tested
Task
Resolves #159
Checklist:
make validationlocally with success