Skip to content

Conversation

@GMinucci
Copy link
Collaborator

@GMinucci GMinucci commented May 3, 2022

What does this PR do

Allows user to set the BundleID for a specific variant.

Extra changes

  • Moved signing validation from Configuration to the iOSVariant object itself.
  • Fixed typo with a misleading instruction present in the variants config file template
  • Clean up BB Team ID from test data

How can it be tested

AC 1:
GIVEN I want to fully customize my app variant BundleID
WHEN I add the key bundle_id to the variant config
AND I run switch command to the specific variant
THEN I should see my app with the exact BundleID as configured

AC 2:
GIVEN I added both bundle_id and id_suffix to my variant config
WHEN I run switch command to the specific variant
THEN I should get an error as both configs are not compatible at same time

Task

Resolves #159

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@GMinucci GMinucci added enhancement New feature or request iOS labels May 3, 2022
@GMinucci GMinucci added this to the Release 1.1.0 milestone May 3, 2022
@GMinucci GMinucci requested review from a user, gderaco and shehan-bb May 3, 2022 12:17
@GMinucci GMinucci self-assigned this May 3, 2022
@ghost
Copy link

ghost commented May 3, 2022

Warnings
⚠️ Pull request is relatively big. If this PR contains multiple changes, consider splitting it into separate PRs for easier reviews.

Generated by 🚫 Danger Swift against 02ad852

GMinucci and others added 2 commits May 3, 2022 15:00
Co-authored-by: obackbase <46746140+obackbase@users.noreply.github.com>
@GMinucci GMinucci requested a review from a user May 3, 2022 13:02
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #173 (02ad852) into develop (2a0bec8) will increase coverage by 0.56%.
The diff coverage is 98.93%.

@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
+ Coverage    71.90%   72.46%   +0.56%     
===========================================
  Files           36       36              
  Lines         1242     1264      +22     
  Branches       441      451      +10     
===========================================
+ Hits           893      916      +23     
+ Misses         309      308       -1     
  Partials        40       40              
Impacted Files Coverage Δ
...riantsCore/Factory/FastlaneParametersFactory.swift 55.40% <0.00%> (ø)
...VariantsCore/Custom Types/Project/iOSProject.swift 79.28% <100.00%> (ø)
...es/VariantsCore/Schemas/iOS/iOSConfiguration.swift 100.00% <100.00%> (ø)
Sources/VariantsCore/Schemas/iOS/iOSVariant.swift 100.00% <100.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0bec8...02ad852. Read the comment docs.

@GMinucci GMinucci requested a review from gderaco May 19, 2022 07:52
@gderaco gderaco closed this May 23, 2022
@gderaco gderaco reopened this May 23, 2022
@gderaco
Copy link
Contributor

gderaco commented May 23, 2022

PR is approved by 2 people, yet it can't be merged because a build hasn't started, therefore cannot report its completion.

@gderaco gderaco merged commit ba3e275 into develop May 23, 2022
@gderaco gderaco deleted the feature/change-ios-bundle-for-variant branch May 23, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration to change iOS bundle identifier for variant

4 participants