Skip to content

Conversation

@GMinucci
Copy link
Collaborator

@GMinucci GMinucci commented Jan 20, 2025

What does this PR do

Propagates global custom properties to all variants

How can it be tested

Add a global custom property and confirm it's available in the variant generated custom properties

Task

resolves #247
resolves #243

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@GMinucci GMinucci requested a review from arthurpalves January 20, 2025 15:58
@GMinucci GMinucci self-assigned this Jan 20, 2025
@GMinucci GMinucci merged commit 63c41d6 into develop Jan 21, 2025
5 checks passed
@GMinucci GMinucci deleted the feat/247-propagate-global-properties branch January 21, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global custom properties are not added for iOS projects [iOS] Platform custom variables not generated

3 participants