Add general generics support to B2Json. #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for different Type implementations.
This allows removal of the static getUnitializedFieldHandler method, which means simplifies the code paths taken during recursive handler generation.
…Make resolution by type private.
…d of getHandledClass method.
bwbeach
approved these changes
Dec 13, 2019
Contributor
bwbeach
left a comment
bwbeach
left a comment
There was a problem hiding this comment.
This is really nice! Thanks for doing it.
| // class Dataset { | ||
| // private List<Double> measurements; | ||
| // } | ||
| if (type instanceof ParameterizedType) { |
Contributor
There was a problem hiding this comment.
The type here is from the field, right? It's the List<Double>?
Having the class Dataset in the comment above is a little confusing.
| if (typeMap == null) { | ||
| throw new RuntimeException("Cannot resolve type " + type + " - the typeMap is empty"); | ||
| } | ||
| return typeMap.get(type.getTypeName()); |
nbehrens-bz
pushed a commit
that referenced
this pull request
May 12, 2025
DP-842 - use venv for b2 upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for (de)serialization of class hierarchies that contain generics. As long as the root class provides all the context necessary, we should be able to resolve any nested types by propagating type parameters down.
This changes the mapping from class -> handler to type -> handler. The recursion is more streamlined (no more
staticgetUnitializedFieldHandler()method). If handlers are tied to parameteric types, they are cached by class and type arguments to avoid collisions.This PR is broken in many many small PRs, so it can be reviewed in small steps as well as by just comparing straight to master. Hopefully that is helpful. The unit tests pass at each intermediate commit.