[SVRENG-1594] restrict max payload length for slack webhooks#186
Merged
asullivan-blze merged 2 commits intomainfrom Jul 29, 2025
Merged
Conversation
- The maximum payload length for text entries is 3000, however 2000 is excessive in its own right; constrain at 2000, direct to the log if anything is ever truncated (e.g., a hyper long error message if a retry loop is constantly attempting health checks). - Slightly simplify the test cases; not _quite_ sure what went pear shaped, but trying to match the entire error event seemed to not go well. - Remove use of a context manager on `Path()`; seems to be a Python 3.13.x change? - Updates pyproject.toml, refactoring deprecated items.
…d up to the project section
asullivan-blze
deleted the
kphoenix-svreng-1594-constrain-slack-webhook-payload-length
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Path(); seems to be a Python 3.13.x change?How was this tested?
make testlocally; no errors.Checklist
versionin the[tool.poetry]section ofthe
pyproject.tomlfile (if applicable)?