Skip to content

Re-auth'ing with Google Oauth shouldn't rm roles#52

Merged
m4wh6k merged 2 commits intomainfrom
bugfix-google-user-login
Dec 20, 2022
Merged

Re-auth'ing with Google Oauth shouldn't rm roles#52
m4wh6k merged 2 commits intomainfrom
bugfix-google-user-login

Conversation

@m4wh6k
Copy link
Copy Markdown
Contributor

@m4wh6k m4wh6k commented Dec 20, 2022

What and why?

I found a bug where authenticating with Google Oauth2 causes user roles to be reset. This fixes that issue

How was this tested?

Tested locally using a development Google Oauth ID/token pair

Checklist

  • Have you updated the VERSION file (if applicable)?

Copy link
Copy Markdown
Contributor

@asullivan-blze asullivan-blze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m4wh6k m4wh6k merged commit 81a13b1 into main Dec 20, 2022
@m4wh6k m4wh6k deleted the bugfix-google-user-login branch December 20, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants