boardwalk (bug): relax type checking for the moment#58
Merged
asullivan-blze merged 3 commits intomainfrom Oct 3, 2023
Merged
Conversation
Something changed with Pydantic, Pyright, or both, such that the previously working 0.8.13 release does not work as expected and Pydantic is throwing errors at runtime. This relaxes type checking--for the moment--to allow the code to run as it did before. Fixes #57.
The version in the GitHub Actions was newer than that installed locally, so an update and reformat was required.
Sweeps more typing issues under the rug (uncovered by GitHub Actions using a newer version of Pyright/Pydantic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something changed with Pydantic, Pyright, or both, such that the previously working
0.8.13release does not work as expected and Pydantic is throwing errors at runtime. This relaxes type checking--for the moment--to allow the code to run as it did before.Fixes #57.
What and why?
See Issue #57; short version, Pydantic is throwing errors, and is preventing use of the package.
How was this tested?
Executing
make develop-serverto get a locally running boardwalkd server instance for the Boardwalkfile to connect to, then running theShouldSucceedTestWorkspacein check mode againstlocalhost. No runtime errors were thrown, as expected.Checklist