Skip to content

boardwalk (bug): add model field annotations#60

Merged
asullivan-blze merged 1 commit intomainfrom
issue59-resolve-runtime-errors
Oct 4, 2023
Merged

boardwalk (bug): add model field annotations#60
asullivan-blze merged 1 commit intomainfrom
issue59-resolve-runtime-errors

Conversation

@asullivan-blze
Copy link
Copy Markdown
Contributor

Missing annotations lead to runtime errors from Pydantic; also bump Pydantic to v2.

What and why?

Resolves #59.

How was this tested?

Locally via make develop-server, and running a test workspace.

Checklist

  • Have you updated the VERSION file (if applicable)?

@asullivan-blze asullivan-blze added the bug Something isn't working label Oct 4, 2023
@asullivan-blze asullivan-blze self-assigned this Oct 4, 2023
dhubka
dhubka previously approved these changes Oct 4, 2023
Copy link
Copy Markdown

@dhubka dhubka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Missing annotations lead to runtime errors from Pydantic; also bump Pydantic to v2.
Copy link
Copy Markdown

@dhubka dhubka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@asullivan-blze asullivan-blze merged commit 401d633 into main Oct 4, 2023
@asullivan-blze asullivan-blze deleted the issue59-resolve-runtime-errors branch October 4, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boardwalk (bug): Not all model fields annotated, causing runtime errors

2 participants