Skip to content

Conversation

@rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Jan 22, 2018

Adds simple lightweight counters to each of the public API methods, event counts, etc. The idea here is that we can begin getting better insight into which operations are the most common in real applications. This will help us know which things are more important from a performance perspective...

@rwjblue
Copy link
Collaborator Author

rwjblue commented Jan 22, 2018

Thoughts @krisselden / @stefanpenner?

Adds simple lightweight counters to each of the public API methods,
event counts, etc.  The idea here is that we can begin getting better
insight into which operations are the most common in _real_
applications. This will help us know which things are more important
from a performance perspective...
@rwjblue
Copy link
Collaborator Author

rwjblue commented Jan 22, 2018

Dist output impact:

Before

-rw-r--r--  1 rjackson  101   9.8K Jan 21 23:40 backburner.min.js
-rw-r--r--  1 rjackson  101   3.1K Jan 21 23:40 backburner.min.js.gz

After

-rw-r--r--  1 rjackson  101    11K Jan 21 23:41 backburner.min.js
-rw-r--r--  1 rjackson  101   3.4K Jan 21 23:41 backburner.min.js.gz

@stefanpenner
Copy link
Collaborator

Sounds useful, abit bummed out that it increases the payload, but not really by much. :shipit:

@rwjblue rwjblue merged commit 7370fcb into BackburnerJS:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants