Skip to content

assignRole response value must be void #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vengrov merged 2 commits into from
Apr 25, 2016
Merged

assignRole response value must be void #28

vengrov merged 2 commits into from
Apr 25, 2016

Conversation

@vengrov
Copy link
Member

@vengrov vengrov commented Apr 25, 2016

  • fix (ajax) empty string in async callback if server response has no body in node env. Must be undefined
  • fix (users) assignRole and unassignRole must be void in async mode
  • refactor (users) rename username argument name to identity for assignRole and unassignRole methods

@vengrov
fix (users) assignRole and unassignRole must be void in async
ae46f05 
- fix (ajax) empty string in async callback if server response has no body in node env. Must be undefined
@vengrov vengrov merged commit df7b93d into master Apr 25, 2016
@vengrov vengrov deleted the assignRoleResponseFix branch April 25, 2016 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Valodya Valodya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vengrov @Valodya