Fixes a race condition during idle connections timing out; Fixes older requests not being reset#1698
Merged
Fixes a race condition during idle connections timing out; Fixes older requests not being reset#1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
In the timeout callback handler, the CancellationToken and State were being set in the wrong order, meaning the token was cancelled and then the state set to "Timeout". This meant the request receiver could "finish processing" and attempt to pass empty requests through to Pode.
The lines have now been flipped, so State is observed appropriately. Additional old requests will now be reset, to clear out older data.
Related Issue