Set default dataSyncRound and CEL check

[kebe7jun]

Fix #6

[gemini-code-assist]

Summary of Changes

Hello @kebe7jun, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the Dataset CRD by setting a default value for dataSyncRound and adding a check to ensure it is greater than zero. It also adds a description for the status field in the PersistentVolumeClaimCondition schema for better clarity.

Highlights

• DataSyncRound Default Value: Sets the default value for dataSyncRound to 1 in the DatasetSpec.
• CEL Validation Rule: Enhances the CEL validation rule for dataSyncRound to ensure it's greater than 0 and can only be incremented by 1.
• PVC Condition Status Description: Adds a description for the status field in the PersistentVolumeClaimCondition schema.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request sets a default value for dataSyncRound and adds a CEL check for it. The new validation rule has a flaw that would prevent users from creating a Dataset with a dataSyncRound greater than 1. I've provided suggestions to correct this behavior for both the Go type definition and the generated CRD YAML. Addressing this will ensure the API is robust for both create and update operations.

[gemini-code-assist]

The validation rule will cause an error during resource creation if dataSyncRound is set to a value greater than 1. On creation, oldSelf is 0, so self - oldSelf <= 1 becomes self <= 1. This is too restrictive and the rule should only apply the increment check on updates.

Suggested change

	// +kubebuilder:validation:XValidation:rule="self > 0 && self - oldSelf <= 1",message="dataSyncRound can only be incremented by 1"
	// +kubebuilder:validation:XValidation:rule="self > 0 && (oldSelf == 0 || self - oldSelf <= 1)",message="dataSyncRound can only be incremented by 1"

[gemini-code-assist]

This validation rule will prevent creating a resource with dataSyncRound greater than 1. On creation, oldSelf is 0, which makes the rule self - oldSelf <= 1 equivalent to self <= 1.

                  rule: self > 0 && (oldSelf == 0 || self - oldSelf <= 1)