Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical dependency issue that caused a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a ModuleNotFoundError: No module named 'pkg_resources' by pinning setuptools to versions older than 81 in the data-loader.Dockerfile. However, a security audit revealed potential secret leakage vulnerabilities in the Hugging Face and ModelScope data loaders, where authentication tokens are passed as command-line arguments and may be logged in plain text. These issues should be addressed to prevent the exposure of sensitive credentials. Additionally, the PR includes a good housekeeping change by adding .DS_Store to the .gitignore file. For future maintainability, consider adding a comment explaining the setuptools version pin.
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* && \ | ||
| pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 setuptools && \ | ||
| pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 "setuptools<81" && \ |
There was a problem hiding this comment.
To improve long-term maintainability, it's beneficial to add a comment explaining why setuptools is pinned. This will provide crucial context for future developers, preventing accidental removal of the pin and reintroduction of the bug.
# Pin setuptools: modelscope requires pkg_resources, which is absent in newer versions.
pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 "setuptools<81" && \
fix when use modelscopecli download model throw an exception: no module named 'pkg_resources'
