Skip to content

Fix: no module named 'pkg_resources'#67

Merged
yyzxw merged 1 commit intomainfrom
fix/modelscope-error
Mar 4, 2026
Merged

Fix: no module named 'pkg_resources'#67
yyzxw merged 1 commit intomainfrom
fix/modelscope-error

Conversation

@yyzxw
Copy link
Contributor

@yyzxw yyzxw commented Mar 4, 2026

fix when use modelscopecli download model throw an exception: no module named 'pkg_resources'
image

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical dependency issue that caused a no module named 'pkg_resources' error during model downloads within the data-loader Docker environment. The fix involves explicitly constraining the setuptools package version to ensure compatibility and prevent the import error. Additionally, it includes a minor cleanup by adding .DS_Store to the .gitignore file.

Highlights

  • Dependency Resolution: Pinned the setuptools package to a version less than 81 in data-loader.Dockerfile to resolve a no module named 'pkg_resources' error when downloading models.
  • Repository Cleanup: Added .DS_Store to the .gitignore file to prevent macOS-specific metadata files from being tracked in the repository.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a ModuleNotFoundError: No module named 'pkg_resources' by pinning setuptools to versions older than 81 in the data-loader.Dockerfile. However, a security audit revealed potential secret leakage vulnerabilities in the Hugging Face and ModelScope data loaders, where authentication tokens are passed as command-line arguments and may be logged in plain text. These issues should be addressed to prevent the exposure of sensitive credentials. Additionally, the PR includes a good housekeeping change by adding .DS_Store to the .gitignore file. For future maintainability, consider adding a comment explaining the setuptools version pin.

apt-get clean && \
rm -rf /var/lib/apt/lists/* && \
pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 setuptools && \
pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 "setuptools<81" && \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve long-term maintainability, it's beneficial to add a comment explaining why setuptools is pinned. This will provide crucial context for future developers, preventing accidental removal of the pin and reintroduction of the bug.

    # Pin setuptools: modelscope requires pkg_resources, which is absent in newer versions.
    pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 "setuptools<81" && \

@BaizeAI BaizeAI deleted a comment from Copilot AI Mar 4, 2026
@yyzxw yyzxw merged commit 87f307d into main Mar 4, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant