Refactor Options Menu #259
Conversation
The options menu is getting way too big and messy, this re-organizes it into more tabs, so that more options can be added and its less overwhelming and more organized. Also adds preview (non-functioning) options for the upcoming preview and order disable options being added in stephs bigger refactor of stuff later.
stephenkirk
left a comment
stephenkirk
left a comment
There was a problem hiding this comment.
Good job with this! I've yet to run it but code overall looks solid
| local function send_lobby_options(value) | ||
| MP.ACTIONS.lobby_options() | ||
| end |
There was a problem hiding this comment.
Note to self to find a better abstraction for this so we don't need to duplicate it
ui/components/lobby_advanced_tab.lua
Outdated
| local Disableable_Toggle = MP.UI.Disableable_Toggle | ||
| local Disableable_Button = MP.UI.Disableable_Button | ||
|
|
localization/en-us.lua
Outdated
| k_opts_gm = "Gamemode Modifiers", | ||
| k_opts_gen = "General", | ||
| k_opts_game = "Gameplay", | ||
| k_opts_gm = "Modifiers", | ||
| k_opts_adv = "Advanced", |
There was a problem hiding this comment.
realize you're inheriting this but think k_lobby prefix would better distinguish visual tabs from actual options (like k_lobby_gameplay)
also: strong pref for avoiding abbrevs unless truly necessary - just write general, gameplay, modifiers etc. bytes are cheap and clarity > brevity for anything that isn't extremely unwieldy
There was a problem hiding this comment.
Good idea, will change
| colour = G.C.BOOSTER, | ||
| tabs = { | ||
| { | ||
| label = localize("k_lobby_options"), |
There was a problem hiding this comment.
k_lobby_options isn't used anymore, it can probably be removed from the localization files. Not sure if I can just remove that though without breaking other stuff
Changed the localization tags, and also removed some unnecessary lines
2 participants
The options menu is getting way too big and messy, this re-organizes it into more tabs, so that more options can be added and its less overwhelming and more organized. Also adds preview (non-functioning) options for the upcoming preview and order disable options being added in stephs bigger refactor of stuff later.