fix: add default log filters for HikariDataSource and TableUtils#34
Merged
Conversation
After BanManager routes HikariCP/ORMLite output through the plugin logger instead of System.err, these messages become visible to WebEnhancer's log appender. Add default ignoreContains entries to filter out DB startup noise from report logs, and add E2E tests for the new filters. Related: BanManagement/BanManager#1050
The e2e config files are bind-mounted into Docker containers and since ignoreContains already exists, copyDefaults(true) won't append new entries from the JAR defaults.
NormalMarkerTableUtils_ contained the substring 'TableUtils' and was being filtered by the very ignoreContains rule under test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After BanManager routes HikariCP/ORMLite output through the plugin logger instead of System.err, these messages become visible to WebEnhancer's log appender. Add default ignoreContains entries to filter out DB startup noise from report logs, and add E2E tests for the new filters.
Related: BanManagement/BanManager#1050