Conversation
Two small cleanups salvaged from the closed #36 that #40 didn't pick up: - buildSrc/LibsConfig.kt: bump the libs module's source/target compatibility and TARGET_JVM_VERSION attribute from 1.8 to 17, matching the v8 Java 17 baseline already applied to the rest of the project in #40. - PinCommand.java: replace the two remaining sender.sendMessage(Message.get(...).toString()) calls with Message.get(...).sendTo(sender) so error messages render through the MiniMessage pipeline like the other pin messages instead of as the raw Component.toString() output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small cleanups salvaged from the now-closed #36 that #40 didn't pick up.
buildSrc/src/main/kotlin/LibsConfig.kt— bump thelibsmodule'ssourceCompatibility/targetCompatibilityand the publishedTargetJvmVersion.TARGET_JVM_VERSION_ATTRIBUTEfrom1.8→17. chore: drop Sponge7 support, bump to Java 17, extend CI to release/v7 #40 raised the rest of the project's Java baseline to 17 (inCommonConfig.kt) but left thelibsmodule pinned at 1.8, so its published artifact metadata still advertised JVM 8 even though the contents were now compiled by a Java 17 toolchain. This brings them into agreement.common/.../commands/PinCommand.java— replace the two remainingsender.sendMessage(Message.get("sender.error.exception").toString())calls withMessage.get("sender.error.exception").sendTo(sender), matching the style used everywhere else in the file (and the rest of the v8 codebase) so the error is rendered through the MiniMessage pipeline rather than as the rawComponent.toString()output.No behaviour changes beyond those two lines of error rendering and the
libsJAR's published metadata.Test plan
./gradlew :BanManagerWebEnhancerCommon:compileJava— green locally../gradlew :BanManagerWebEnhancerLibs:jarruns as part of the above and produces a Java 17 jar without warnings.Java CIbuild + the 10 E2E suites (no behaviour change expected).Context