Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The v0.0.1-beta release dropped `band.rb` at the repo root of Bandwidth/homebrew-tap, but Homebrew prefers `Formula/` and the tap already had a `Formula/band.rb` (a placeholder from initial setup). Result: two duplicate formulas and a broken `brew install`. Add `directory: Formula` to the brews block so future releases write to `Formula/band.rb` directly, keeping the formula in the canonical location and avoiding a second duplicate on the next release. Known follow-up on the tap side: GoReleaser always writes an explicit `version "X.Y.Z"` line in the generated formula, which the tap's `brew audit --strict` flags as redundant with the version scanned from the release URL. Every auto-generated PR will fail audit until the tap drops `--strict` (or excludes that specific warning). Loosening `--strict` on our tap doesn't preclude submitting this formula to homebrew-core later — that's a separate, manually- maintained formula at submission time — and the functional checks (URL reachability, SHA match, Ruby parse, license, structure) all still run without it.
kshahbw
force-pushed
the
fix/goreleaser-brew-formula-dir
branch
from
2f79c50 to
a631dfb
Compare
joshraub-bw
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.0.1-beta dropped
band.rbat the root ofBandwidth/homebrew-tap, but Homebrew prefersFormula/— and the tap already had aFormula/band.rbplaceholder from initial setup. The result was two duplicate formulas on the tap and a brokenbrew install(Homebrew resolved to the old placeholder).Add
directory: Formulato the brews block so future releases write toFormula/band.rbdirectly, not the repo root.Ordering
Merge
Bandwidth/homebrew-tap#5first — that consolidates the current state by replacingFormula/band.rbwith the real v0.0.1-beta content and deleting the root copy. This PR only matters for the next release.Known follow-up on the tap
GoReleaser always writes an explicit
version "X.Y.Z"line in the generated formula. The tap's audit workflow runsbrew audit --strict, which flags that line as redundant with the version scanned from the release URL — and fails the auto-generated PR. This will happen on every release PR until the tap drops--strict(or excludes this specific warning).Loosening
--stricton our own tap doesn't preclude submitting this formula to homebrew-core later — that's a separate, manually-maintained formula at submission time, where we'd fix the redundantversionline then (or by then, GoReleaser may have fixed the template upstream). The functional audit checks — URL reachability, SHA match, Ruby parse, license, structure — all still run without--strict. Tracking as a tap-side change.Test plan
Bandwidth/homebrew-tap#5first, verifybrew install Bandwidth/tap/bandsucceedsFormula/band.rb(not root) and it passes audit